]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestVectoredHandlerExceptionInNonGoThread
authorqmuntal <quimmuntal@gmail.com>
Fri, 21 Oct 2022 07:18:53 +0000 (09:18 +0200)
committerGopher Robot <gobot@golang.org>
Fri, 21 Oct 2022 14:47:46 +0000 (14:47 +0000)
windows-amd-2012 builder seems to have some problems handling
exception thrown in external C code which is affecting
TestVectoredHandlerExceptionInNonGoThread.
The issue is known and discussed in #49681.

This Cl skips the offending test on windows-amd-2012.

Change-Id: I7ca4353c9e531f0d75ac6a8dbd809acfa1f15bf9
Reviewed-on: https://go-review.googlesource.com/c/go/+/444616
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/runtime/signal_windows_test.go

index 02497e6fae24310c736f4ca866ce5bd18973627c..b27eca9b60fbae07f2d3791219c783228d0bd2b8 100644 (file)
@@ -21,6 +21,9 @@ func TestVectoredHandlerExceptionInNonGoThread(t *testing.T) {
        if *flagQuick {
                t.Skip("-quick")
        }
+       if testenv.Builder() == "windows-amd64-2012" {
+               testenv.SkipFlaky(t, 49681)
+       }
        testenv.MustHaveGoBuild(t)
        testenv.MustHaveCGO(t)
        testenv.MustHaveExecPath(t, "gcc")