]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: remove some log spam in test, add missing error detail
authorBrad Fitzpatrick <bradfitz@golang.org>
Thu, 2 Nov 2017 19:17:13 +0000 (19:17 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 2 Nov 2017 20:01:06 +0000 (20:01 +0000)
Updates #22540

Change-Id: I26e79c25652976fac6f2e5a7afb4fd1240996d74
Reviewed-on: https://go-review.googlesource.com/75531
Reviewed-by: Tom Bergan <tombergan@google.com>
Run-TryBot: Tom Bergan <tombergan@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/http/transport_test.go

index 31cf9170665ee6cb1bf9396e5ad5eaf95663a90e..997a9153d0bd92a419ee9f23831b119fe1c1d61c 100644 (file)
@@ -1113,15 +1113,14 @@ func TestTransportProxy(t *testing.T) {
                                                Header:     make(Header),
                                        }
 
-                                       log.Printf("Dialing %s", r.URL.Host)
                                        targetConn, err := net.Dial("tcp", r.URL.Host)
                                        if err != nil {
-                                               t.Errorf("net.Dial failed")
+                                               t.Errorf("net.Dial(%q) failed: %v", r.URL.Host, err)
                                                return
                                        }
 
                                        if err := res.Write(clientConn); err != nil {
-                                               t.Errorf("Writing 200 OK failed")
+                                               t.Errorf("Writing 200 OK failed: %v", err)
                                                return
                                        }