codereview: don't run gofmt with an empty file list

R=gri
CC=golang-dev
https://golang.org/cl/1678054

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 750ae871cad379f83ed447f8ee62439548fcd754..4aeff90678b8abd6773d38ceb0f6bc8de98ce96d 100644 (file)
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -694,6 +694,8 @@ def CheckGofmt(ui, repo, files, just_warn=False):
        cwd = os.getcwd()
        files = [RelativePath(repo.root + '/' + f, cwd) for f in files]
        files = [f for f in files if os.access(f, 0)]
+       if not files:
+               return
        try:
                cmd = subprocess.Popen(["gofmt", "-l"] + files, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
                cmd.stdin.close()