]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go/testdata/script: skip part of test on unsupported platforms
authorMichael Matloob <matloob@golang.org>
Mon, 9 Sep 2024 16:47:33 +0000 (12:47 -0400)
committerGopher Robot <gobot@golang.org>
Mon, 9 Sep 2024 17:11:52 +0000 (17:11 +0000)
The telemetry script test checks for the existence of telemetry data as
a baseline before checking that the act of setting telemtetry to off
while in local mode doesn't produce telemetry data. Of course, when
we're running on platforms where telemetry is not supported, telemetry
data won't be produced on disk either way. Only check for the existence
of telemetry data on supported platforms.

For #69269

Change-Id: I3a06bbc3d3ca0cf0203b84883f632ecfd9445aae
Reviewed-on: https://go-review.googlesource.com/c/go/+/611876
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Matloob <matloob@golang.org>

src/cmd/go/testdata/script/telemetry.txt

index 7edbe66b5f9748d0daae774a4950f1c22a52f766..52bf8dee64e565dd5172983ce4ca460fdd1b1275 100644 (file)
@@ -52,7 +52,8 @@ stderr '^go: GOTELEMETRYDIR cannot be modified$'
 
 # Test issue #69269: 'go telemetry off' should not increment counters.
 # Establish that previous commands did write telemetry files.
-exists $userconfig/go/telemetry/local
+# Only check for the existence of telemetry data on supported platforms.
+[!GOOS:openbsd] [!GOOS:solaris] [!GOOS:android] [!GOOS:illumos] [!GOOS:js] [!GOOS:wasip1] [!GOOS:plan9] [!GOARCH:mips] [!GOARCH:mipsle] exists $userconfig/go/telemetry/local
 # Now check for go telemetry off behavior.
 rm $userconfig/go/telemetry/local
 go telemetry off
@@ -66,4 +67,4 @@ go telemetry -C=$WORK off
 ! exists $userconfig/go/telemetry/local
 go telemetry local
 go help telemetry
-exists $userconfig/go/telemetry/local
+[!GOOS:openbsd] [!GOOS:solaris] [!GOOS:android] [!GOOS:illumos] [!GOOS:js] [!GOOS:wasip1] [!GOOS:plan9] [!GOARCH:mips] [!GOARCH:mipsle] exists $userconfig/go/telemetry/local