[dev.ssa] cmd/compile: reenable TestStackBarrierProfiling

Tested it 1000x on OS X and Linux amd64, no failures.
Updated TODO.

Change-Id: Ia60c8d90962f6e5f7c3ed1ded6ba1b25eee983e1
Reviewed-on: https://go-review.googlesource.com/19662
Reviewed-by: Todd Neal <todd@tneal.org>

diff --git a/src/cmd/compile/internal/ssa/TODO b/src/cmd/compile/internal/ssa/TODO
index 5fa14ee44bb45dcea1d34a02be122326e7e9db29..5e5cb4b865aa96884b6297232ffe8b2337238308 100644 (file)
--- a/src/cmd/compile/internal/ssa/TODO
+++ b/src/cmd/compile/internal/ssa/TODO
@@ -7,7 +7,6 @@ Coverage
 Correctness
 -----------
 - Debugging info (check & fix as much as we can)
-- Re-enable TestStackBarrierProfiling (src/runtime/pprof/pprof_test.go)
 - @ directive in rewrites might read overwritten data.  Save @loc
   in variable before modifying v.
 

diff --git a/src/runtime/pprof/pprof_test.go b/src/runtime/pprof/pprof_test.go
index f7c1a46805adc06909b07829816a18268c6e5512..ab6b1835c570d66ef43e84a319a40237595ea2a5 100644 (file)
--- a/src/runtime/pprof/pprof_test.go
+++ b/src/runtime/pprof/pprof_test.go
@@ -375,11 +375,6 @@ func TestStackBarrierProfiling(t *testing.T) {
                t.Skipf("low resolution timers inhibit profiling signals (golang.org/issue/13405)")
                return
        }
-       if true {
-               // TODO(khr): remove
-               t.Skipf("skipping for SSA branch, flaky")
-               return
-       }
 
        if !strings.Contains(os.Getenv("GODEBUG"), "gcstackbarrierall=1") {
                // Re-execute this test with constant GC and stack