]> Cypherpunks repositories - gostls13.git/commitdiff
net: use IANA reserved port to test dial timeout
authorMikio Hara <mikioh.mikioh@gmail.com>
Wed, 7 Mar 2012 07:28:40 +0000 (16:28 +0900)
committerMikio Hara <mikioh.mikioh@gmail.com>
Wed, 7 Mar 2012 07:28:40 +0000 (16:28 +0900)
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5757060

src/pkg/net/dial_test.go

index f9c47d02bb61a8af74a4c4b569264af82e0f6bea..7212087fe0c98dace02798cef56431e44e4acf19 100644 (file)
@@ -51,12 +51,15 @@ func TestDialTimeout(t *testing.T) {
                // to connecting to a hopefully-dead 127/8 address.
                // Same for windows.
                //
-               // Use a bogus port (44444) instead of 80, because
+               // Use an IANA reserved port (49151) instead of 80, because
                // on our 386 builder, this Dial succeeds, connecting
                // to an IIS web server somewhere.  The data center
                // or VM or firewall must be stealing the TCP connection.
+               // 
+               // IANA Service Name and Transport Protocol Port Number Registry
+               // <http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml>
                go func() {
-                       c, err := DialTimeout("tcp", "127.0.71.111:44444", 200*time.Millisecond)
+                       c, err := DialTimeout("tcp", "127.0.71.111:49151", 200*time.Millisecond)
                        if err == nil {
                                err = fmt.Errorf("unexpected: connected to %s!", c.RemoteAddr())
                                c.Close()