cmd/link: disable flaky Darwin "symbols" test

About one run out of 3 it fails on my laptop, and
I am tired of having to be a nanny for my tests just
because of this one flaky test.  This has been a problem
for months.

Updates #32218.

Change-Id: I2871d4c6f47e9432d189ed7bdcda8f9c0871cfc5
Reviewed-on: https://go-review.googlesource.com/c/go/+/297469
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>

diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go
index db710bed6ab0621a014e6be58a7cdd0fa93309a6..d0284ad4f560ae258a36372fae0288f071bcf9f2 100644 (file)
--- a/src/cmd/link/dwarf_test.go
+++ b/src/cmd/link/dwarf_test.go
@@ -91,7 +91,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)
                                exe = filepath.Join(tmpDir, "go.o")
                        }
 
-                       if runtime.GOOS == "darwin" {
+                       darwinSymbolTestIsTooFlaky := true // Turn this off, it is too flaky -- See #32218
+                       if runtime.GOOS == "darwin" && !darwinSymbolTestIsTooFlaky {
                                if _, err = exec.LookPath("symbols"); err == nil {
                                        // Ensure Apple's tooling can parse our object for symbols.
                                        out, err = exec.Command("symbols", exe).CombinedOutput()