]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: skip TestLinuxSendfile on mips64 for now
authorBrad Fitzpatrick <bradfitz@golang.org>
Tue, 22 Nov 2016 01:43:38 +0000 (01:43 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 22 Nov 2016 02:32:55 +0000 (02:32 +0000)
See issues for details. We can expand this test during the Go 1.9
cycle.

Updates #18008

Change-Id: I78b6b7e8dede414769be97898e29f969bc2a9651
Reviewed-on: https://go-review.googlesource.com/33430
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/net/http/fs_test.go

index 83f81e3efb1f5e1b2d200fed496aec9d2b9c9e49..17a0e4a9af85668c003f92d15923dfd82f723ca2 100644 (file)
@@ -1091,9 +1091,7 @@ func TestLinuxSendfile(t *testing.T) {
                // and will error out if we specify that with `-e trace='.
                syscalls = "sendfile"
        case "mips64":
-               // TODO: minimize this set once golang.org/issue/18008
-               // is understood.
-               syscalls = "network,file"
+               t.Skip("TODO: update this test to be robust against various versions of strace on mips64. See golang.org/issue/33430")
        }
 
        var buf bytes.Buffer