]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: drop nowritebarrier from gcParkAssist
authorMichael Pratt <mpratt@google.com>
Tue, 28 Sep 2021 18:35:03 +0000 (14:35 -0400)
committerMichael Pratt <mpratt@google.com>
Wed, 29 Sep 2021 15:23:27 +0000 (15:23 +0000)
Nothing in this function is at odds with having write barriers. It
originally inherited the annotation from gcAssistAlloc
http://golang.org/cl/30700, which subsequently dropped the annotation in
http://golang.org/cl/32431 as it was unnecessary.

Change-Id: Ie464e6b4ed957f57e922ec043728ff4e15bf35ad
Reviewed-on: https://go-review.googlesource.com/c/go/+/352811
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/mgcmark.go

index 64f1c79c361cf325b3903fb9ee5da2f81022d5cc..eb5221443e7990c80fe601fc53655e052a1ddbb4 100644 (file)
@@ -587,8 +587,6 @@ func gcWakeAllAssists() {
 //
 // gcParkAssist reports whether the assist is now satisfied. If it
 // returns false, the caller must retry the assist.
-//
-//go:nowritebarrier
 func gcParkAssist() bool {
        lock(&work.assistQueue.lock)
        // If the GC cycle finished while we were getting the lock,