]> Cypherpunks repositories - gostls13.git/commitdiff
log/slog: correct doc examples for Handler.WithGroup
authorJes Cok <xigua67damn@gmail.com>
Tue, 5 Dec 2023 04:12:45 +0000 (04:12 +0000)
committerJonathan Amsterdam <jba@google.com>
Tue, 5 Dec 2023 18:18:13 +0000 (18:18 +0000)
Fixes #64519

Change-Id: Iaea5de74402b77eb5a42979bd3baa1276b13d585
GitHub-Last-Rev: 5080a257b2d7aa7c4333d05bdef0b5dcbb0449ed
GitHub-Pull-Request: golang/go#64551
Reviewed-on: https://go-review.googlesource.com/c/go/+/547215
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jes Cok <xigua67damn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/log/slog/handler.go

index 2182bfb609383b4ee88cb841eb6eb3ad6fbb5513..2ff85b582ef32e6335fcd2d7d04ed7814cd7b5e7 100644 (file)
@@ -76,11 +76,11 @@ type Handler interface {
        // A Handler should treat WithGroup as starting a Group of Attrs that ends
        // at the end of the log event. That is,
        //
-       //     logger.WithGroup("s").LogAttrs(level, msg, slog.Int("a", 1), slog.Int("b", 2))
+       //     logger.WithGroup("s").LogAttrs(ctx, level, msg, slog.Int("a", 1), slog.Int("b", 2))
        //
        // should behave like
        //
-       //     logger.LogAttrs(level, msg, slog.Group("s", slog.Int("a", 1), slog.Int("b", 2)))
+       //     logger.LogAttrs(ctx, level, msg, slog.Group("s", slog.Int("a", 1), slog.Int("b", 2)))
        //
        // If the name is empty, WithGroup returns the receiver.
        WithGroup(name string) Handler