]> Cypherpunks repositories - gostls13.git/commitdiff
net/http/cgi: remove outdated TODO
authorTim Cooper <tim.cooper@layeh.com>
Thu, 27 Feb 2020 18:11:30 +0000 (12:11 -0600)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 6 Mar 2020 23:33:17 +0000 (23:33 +0000)
Cookies already work as http.Request parses the Cookie header on-demand
when the Cookie methods are called.

Change-Id: Ib7a6f68be02940ff0b56d2465c94545d6fd43847
Reviewed-on: https://go-review.googlesource.com/c/go/+/221417
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/http/cgi/child.go

index cb140f8f2f643e43b9b47a36bec57ecbac916abe..9474175f1791eba414d2443909580c16ed0c7405 100644 (file)
@@ -89,8 +89,6 @@ func RequestFromMap(params map[string]string) (*http.Request, error) {
                r.Header.Add(strings.ReplaceAll(k[5:], "_", "-"), v)
        }
 
-       // TODO: cookies.  parsing them isn't exported, though.
-
        uriStr := params["REQUEST_URI"]
        if uriStr == "" {
                // Fallback to SCRIPT_NAME, PATH_INFO and QUERY_STRING.