]> Cypherpunks repositories - gostls13.git/commitdiff
internal/trace: skip TestTraceCgoCallback on freebsd-amd64-race builders
authorDmitri Shuralyov <dmitshur@golang.org>
Tue, 4 Feb 2025 03:50:29 +0000 (22:50 -0500)
committerGopher Robot <gobot@golang.org>
Wed, 5 Feb 2025 20:06:13 +0000 (12:06 -0800)
For #71556.

Change-Id: I754f113bfdad244d0e978cf559bf45f2f4d7bf06
Reviewed-on: https://go-review.googlesource.com/c/go/+/646396
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/internal/trace/trace_test.go

index facac47eef06049f2d87f3b9d07088f427c17699..4ff87c1ede6ac680d16fa3fec255dc307be15cfd 100644 (file)
@@ -573,6 +573,11 @@ func testTraceProg(t *testing.T, progName string, extra func(t *testing.T, trace
        onBuilder := testenv.Builder() != ""
        onOldBuilder := !strings.Contains(testenv.Builder(), "gotip") && !strings.Contains(testenv.Builder(), "go1")
 
+       if progName == "cgo-callback.go" && onBuilder && !onOldBuilder &&
+               runtime.GOOS == "freebsd" && runtime.GOARCH == "amd64" && race.Enabled {
+               t.Skip("test fails on freebsd-amd64-race in LUCI; see go.dev/issue/71556")
+       }
+
        testPath := filepath.Join("./testdata/testprog", progName)
        testName := progName
        runTest := func(t *testing.T, stress bool, extraGODEBUG string) {