]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/internal/obj/x86: skip test when GOHOSTARCH is set
authorBrad Fitzpatrick <bradfitz@golang.org>
Wed, 27 Jan 2016 21:18:35 +0000 (13:18 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 27 Jan 2016 21:33:50 +0000 (21:33 +0000)
It's causing the darwin-386 builder to fail with:

--- FAIL: TestDynlink (0.07s)
    obj6_test.go:118: error exit status 3 output go tool: no such tool "asm"
FAIL
FAIL    cmd/internal/obj/x86    0.073s

So skip it for now. It's tested in enough other places.

Change-Id: I9a98ad7b8be807005750112d892ac6c676c17dd5
Reviewed-on: https://go-review.googlesource.com/18989
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/internal/obj/x86/obj6_test.go

index 4387db696d0cbe522e82256188f1927c8b5da355..5fa1d3bfcffb53a04ed3fce37eaec150063a911c 100644 (file)
@@ -150,6 +150,13 @@ func parseOutput(t *testing.T, td *ParsedTestData, asmout []byte) {
 func TestDynlink(t *testing.T) {
        testenv.MustHaveGoBuild(t)
 
+       if os.Getenv("GOHOSTARCH") != "" {
+               // TODO: make this work? It was failing due to the
+               // GOARCH= filtering above and skipping is easiest for
+               // now.
+               t.Skip("skipping when GOHOSTARCH is set")
+       }
+
        testdata := parseTestData(t)
        asmout := asmOutput(t, testdata.input)
        parseOutput(t, testdata, asmout)