]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: enable TestNoteReading on ppc64le
authorLynn Boger <laboger@linux.vnet.ibm.com>
Wed, 25 Oct 2017 19:34:08 +0000 (15:34 -0400)
committerLynn Boger <laboger@linux.vnet.ibm.com>
Wed, 25 Oct 2017 20:20:44 +0000 (20:20 +0000)
This test was previously disabled when external linking was
unsupported on ppc64le. It should still be disabled on ppc64
since there is no cgo or external linking there, but I removed
the if test for GOARCH=ppc64 since the initial test for cgo
enabled will cause it to be skipped on ppc64.

Fixes #22360

Change-Id: I5a0e3e4a1bd71ac7bf0ed0c792f7b78fb4a5e100
Reviewed-on: https://go-review.googlesource.com/73510
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/note_test.go

index d198138d83831aabac76ee2cd91f32c83f6b472b..66c5d39bf772feb02c11dda8f4cbf4cd151ce623 100644 (file)
@@ -32,8 +32,6 @@ func TestNoteReading(t *testing.T) {
        switch {
        case !build.Default.CgoEnabled:
                t.Skipf("skipping - no cgo, so assuming external linking not available")
-       case runtime.GOOS == "linux" && (runtime.GOARCH == "ppc64le" || runtime.GOARCH == "ppc64"):
-               t.Skipf("skipping - external linking not supported, golang.org/issue/11184")
        case runtime.GOOS == "openbsd" && runtime.GOARCH == "arm":
                t.Skipf("skipping - external linking not supported, golang.org/issue/10619")
        case runtime.GOOS == "plan9":