go/types,types2: exclude tests that need cgo.Incomplete

Since when go/types,types2 do not know about build constraints, and
runtime/cgo.Incomplete is only available on platforms that support cgo.

These tests are also failing on aix with failure from linker, so disable
them on aix to make builder green. The fix for aix is tracked in #54814

Updates #46731
Updates #54814

Change-Id: I5d6f6e29a8196efc6c457ea64525350fc6b20309
Reviewed-on: https://go-review.googlesource.com/c/go/+/427394
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>

diff --git a/src/cmd/compile/internal/types2/stdlib_test.go b/src/cmd/compile/internal/types2/stdlib_test.go
index fc541a4b4522ee3df1a8e56a94be064aa15bf142..2577abf6de9b61d4b1bb7a90b7eaf3c9dd4615d8 100644 (file)
--- a/src/cmd/compile/internal/types2/stdlib_test.go
+++ b/src/cmd/compile/internal/types2/stdlib_test.go
@@ -197,6 +197,15 @@ func TestStdFixed(t *testing.T) {
                "issue48230.go",  // go/types doesn't check validity of //go:xxx directives
                "issue49767.go",  // go/types does not have constraints on channel element size
                "issue49814.go",  // go/types does not have constraints on array size
+
+               // These tests requires runtime/cgo.Incomplete, which is only available on some platforms.
+               // However, types2 does not know about build constraints.
+               "bug514.go",
+               "issue40954.go",
+               "issue42032.go",
+               "issue42076.go",
+               "issue46903.go",
+               "issue51733.go",
        )
 }
 

diff --git a/src/go/types/stdlib_test.go b/src/go/types/stdlib_test.go
index d75729ac3997cb317b73898802e4beaef0abf282..53333b69db9df00bde1a767eec5a5c6440c1d885 100644 (file)
--- a/src/go/types/stdlib_test.go
+++ b/src/go/types/stdlib_test.go
@@ -199,6 +199,15 @@ func TestStdFixed(t *testing.T) {
                "issue48230.go",  // go/types doesn't check validity of //go:xxx directives
                "issue49767.go",  // go/types does not have constraints on channel element size
                "issue49814.go",  // go/types does not have constraints on array size
+
+               // These tests requires runtime/cgo.Incomplete, which is only available on some platforms.
+               // However, go/types does not know about build constraints.
+               "bug514.go",
+               "issue40954.go",
+               "issue42032.go",
+               "issue42076.go",
+               "issue46903.go",
+               "issue51733.go",
        )
 }
 

diff --git a/test/fixedbugs/bug514.go b/test/fixedbugs/bug514.go
index 9b2318533782588ed1cc9ea3b764615e2819c2b6..1a6c7f14dd784a8c5ca174694b720a8a49c1ad6d 100644 (file)
--- a/test/fixedbugs/bug514.go
+++ b/test/fixedbugs/bug514.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-//go:build cgo
+//go:build cgo && !aix
 
 package main
 

diff --git a/test/fixedbugs/issue40954.go b/test/fixedbugs/issue40954.go
index 0beaabb7439755853d0f4d247e423b3b40bf11a1..e268b808ca14235596b837c29ae45c398891d34c 100644 (file)
--- a/test/fixedbugs/issue40954.go
+++ b/test/fixedbugs/issue40954.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-//go:build cgo
+//go:build cgo && !aix
 
 package main
 

diff --git a/test/fixedbugs/issue42032.go b/test/fixedbugs/issue42032.go
index eb118591019e7322d7dc30e232c0fc0d35225afe..68fbc890458cf76daec42d2f1288ff8a8c2b9478 100644 (file)
--- a/test/fixedbugs/issue42032.go
+++ b/test/fixedbugs/issue42032.go
@@ -4,7 +4,7 @@
 // source code is governed by a BSD-style license that can be found in
 // the LICENSE file.
 
-//go:build cgo
+//go:build cgo && !aix
 
 package main
 

diff --git a/test/fixedbugs/issue42076.go b/test/fixedbugs/issue42076.go
index ef8db2da30d68556ea8e38d1ed9344d130a61258..b958d0eeb50b50c9f8e7fac9ad022e34911559b8 100644 (file)
--- a/test/fixedbugs/issue42076.go
+++ b/test/fixedbugs/issue42076.go
@@ -4,7 +4,7 @@
 // source code is governed by a BSD-style license that can be found in
 // the LICENSE file.
 
-//go:build cgo
+//go:build cgo && !aix
 
 package main
 

diff --git a/test/fixedbugs/issue46903.go b/test/fixedbugs/issue46903.go
index d77564add2e9c52f7cb12b36fc34f64a09fb20bc..90ceb9a86c2e6579610800701712627a2e6f2583 100644 (file)
--- a/test/fixedbugs/issue46903.go
+++ b/test/fixedbugs/issue46903.go
@@ -1,6 +1,5 @@
 // run
-//go:build goexperiment.unified && cgo
-// +build goexperiment.unified,cgo
+//go:build goexperiment.unified && cgo && !aix
 
 // TODO(mdempsky): Enable test unconditionally. This test should pass
 // for non-unified mode too.

diff --git a/test/fixedbugs/issue51733.go b/test/fixedbugs/issue51733.go
index 933c3e868c0545c81635ed438352ae571b359976..757ef733c3fff86d7879c14b44d9b6d37c84c9af 100644 (file)
--- a/test/fixedbugs/issue51733.go
+++ b/test/fixedbugs/issue51733.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-//go:build cgo
+//go:build cgo && !aix
 
 package main