]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip GDB tests on NetBSD
authorIan Lance Taylor <iant@golang.org>
Tue, 28 Nov 2017 00:48:48 +0000 (16:48 -0800)
committerIan Lance Taylor <iant@golang.org>
Tue, 28 Nov 2017 01:18:54 +0000 (01:18 +0000)
TestGdbAutotmpTypes times out for unknown reasons on NetBSd. Skip the
gdb tests on NetBSD for now.

Updates #22893

Change-Id: Ibb05b7260eabb74d805d374b25a43770939fa5f2
Reviewed-on: https://go-review.googlesource.com/80136
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/runtime/runtime-gdb_test.go

index f0922e16b58e1b8742e3c74290571c857b550040..fe62f96e860b775971755ef477c63021bde3548e 100644 (file)
@@ -22,11 +22,15 @@ import (
 
 func checkGdbEnvironment(t *testing.T) {
        testenv.MustHaveGoBuild(t)
-       if runtime.GOOS == "darwin" {
+       switch runtime.GOOS {
+       case "darwin":
                t.Skip("gdb does not work on darwin")
-       }
-       if runtime.GOOS == "linux" && runtime.GOARCH == "ppc64" {
-               t.Skip("skipping gdb tests on linux/ppc64; see golang.org/issue/17366")
+       case "netbsd":
+               t.Skip("test times out on NetBSD for unknown reasons; issue 22893")
+       case "linux":
+               if runtime.GOARCH == "ppc64" {
+                       t.Skip("skipping gdb tests on linux/ppc64; see golang.org/issue/17366")
+               }
        }
        if final := os.Getenv("GOROOT_FINAL"); final != "" && runtime.GOROOT() != final {
                t.Skip("gdb test can fail with GOROOT_FINAL pending")