]> Cypherpunks repositories - gostls13.git/commitdiff
net/rpc: fix args order in strings.Contains call
authorIskander Sharipov <quasilyte@gmail.com>
Tue, 5 Feb 2019 10:29:29 +0000 (13:29 +0300)
committerDaniel Martí <mvdan@mvdan.cc>
Tue, 26 Feb 2019 17:51:35 +0000 (17:51 +0000)
The old code looks suspicious and is fragile.
It would fail if error messages were not totally the same.
Swapped the arguments order to fix that.

Change-Id: Id5df7242fb9224d0090245286ef8986ebb15e921
Reviewed-on: https://go-review.googlesource.com/c/161157
Run-TryBot: Iskander Sharipov <quasilyte@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
src/net/rpc/client_test.go

index d116d2acc9aa29ec74a93ba15201c2cf31d6c379..03225e3d0104b5277d8a0af2fea98be725676c02 100644 (file)
@@ -57,7 +57,7 @@ func TestGobError(t *testing.T) {
                if err == nil {
                        t.Fatal("no error")
                }
-               if !strings.Contains("reading body EOF", err.(error).Error()) {
+               if !strings.Contains(err.(error).Error(), "reading body EOF") {
                        t.Fatal("expected `reading body EOF', got", err)
                }
        }()