]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: treat TestRaceSignal as flaky on Darwin
authorIan Lance Taylor <iant@golang.org>
Mon, 22 May 2023 18:38:46 +0000 (11:38 -0700)
committerGopher Robot <gobot@golang.org>
Mon, 22 May 2023 19:03:04 +0000 (19:03 +0000)
It should be impossible for the program to exit with SIGCHLD,
but it happens occasionally. Skip the test on Darwin.

For #60316

Change-Id: Idc9d89838e73f077afc42a9703554d61ac7a0069
Reviewed-on: https://go-review.googlesource.com/c/go/+/497055
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>

src/runtime/crash_cgo_test.go

index 2a07678b521701d8dfaf3f274c70045c785d8751..e3417527c49dfb131e3f5ef30ed0c40bc41b160d 100644 (file)
@@ -410,6 +410,9 @@ func TestRaceSignal(t *testing.T) {
                t.Skipf("skipping: test requires pthread support")
                // TODO: Can this test be rewritten to use the C11 thread API instead?
        }
+       if runtime.GOOS == "darwin" || runtime.GOOS == "ios" {
+               testenv.SkipFlaky(t, 60316)
+       }
 
        t.Parallel()