]> Cypherpunks repositories - gostls13.git/commitdiff
strconv: remove some test TODOs and adjust malloc limits lower
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 5 Apr 2013 00:04:18 +0000 (17:04 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 5 Apr 2013 00:04:18 +0000 (17:04 -0700)
These no longer allocate.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/8340047

src/pkg/strconv/strconv_test.go

index 3cd7835cccb30ed511100fe357993796f7369bda..40ab4ce6a4dc871e988cd8f9440c4409e0607b17 100644 (file)
@@ -20,14 +20,12 @@ var (
                desc  string
                fn    func()
        }{
-               // TODO(bradfitz): this might be 0, once escape analysis is better
-               {1, `AppendInt(localBuf[:0], 123, 10)`, func() {
+               {0, `AppendInt(localBuf[:0], 123, 10)`, func() {
                        var localBuf [64]byte
                        AppendInt(localBuf[:0], 123, 10)
                }},
                {0, `AppendInt(globalBuf[:0], 123, 10)`, func() { AppendInt(globalBuf[:0], 123, 10) }},
-               // TODO(bradfitz): this might be 0, once escape analysis is better
-               {1, `AppendFloat(localBuf[:0], 1.23, 'g', 5, 64)`, func() {
+               {0, `AppendFloat(localBuf[:0], 1.23, 'g', 5, 64)`, func() {
                        var localBuf [64]byte
                        AppendFloat(localBuf[:0], 1.23, 'g', 5, 64)
                }},