]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.13] net/http: make docs refer to Context.Value as a getter instea...
authorKevin Gillette <extemporalgenome@gmail.com>
Mon, 26 Aug 2019 03:30:21 +0000 (03:30 +0000)
committerAndrew Bonventre <andybons@golang.org>
Mon, 2 Sep 2019 21:51:40 +0000 (21:51 +0000)
The doc comments of both ServerContextKey and LocalAddrContextKey both suggest that context.WithValue can be used to access (get) properties of the server or connection. This PR fixes those comments to refer to Context.Value instead.

Change-Id: I4ed383ef97ba1951f90c555243007469cfc18d4d
GitHub-Last-Rev: 05bc3acf82322e3dc77abc7fa0412efe01a77eac
GitHub-Pull-Request: golang/go#33833
Reviewed-on: https://go-review.googlesource.com/c/go/+/191838
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 8b03a3992bc755eadbccc10d97adc21d0b229401)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191750
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/http/server.go

index 2eb16ff632c7346e84c9526697262a899b7d70ca..f554c813000480baf97ae99f19df38404320198d 100644 (file)
@@ -231,13 +231,13 @@ type CloseNotifier interface {
 
 var (
        // ServerContextKey is a context key. It can be used in HTTP
-       // handlers with context.WithValue to access the server that
+       // handlers with Context.Value to access the server that
        // started the handler. The associated value will be of
        // type *Server.
        ServerContextKey = &contextKey{"http-server"}
 
        // LocalAddrContextKey is a context key. It can be used in
-       // HTTP handlers with context.WithValue to access the local
+       // HTTP handlers with Context.Value to access the local
        // address the connection arrived on.
        // The associated value will be of type net.Addr.
        LocalAddrContextKey = &contextKey{"local-addr"}