]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: remove some obsolete TODOs
authorBrad Fitzpatrick <bradfitz@golang.org>
Thu, 4 Apr 2013 20:40:26 +0000 (13:40 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 4 Apr 2013 20:40:26 +0000 (13:40 -0700)
We've decided to leave logging to third-parties (there are too
many formats), which others have done.

And we can't change the behavior of the various response
fields at this point anyway. Plus I argue they're correct and
match their documention.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8391043

src/pkg/net/http/response_test.go
src/pkg/net/http/server.go

index 49836ce2cc585912a3bf6a77244f56e3c67be118..02796e88b4c4453ea2543fb44eebe6efbd486df1 100644 (file)
@@ -112,8 +112,8 @@ var respTests = []respTest{
                        ProtoMinor: 0,
                        Request:    dummyReq("GET"),
                        Header: Header{
-                               "Connection":     {"close"}, // TODO(rsc): Delete?
-                               "Content-Length": {"10"},    // TODO(rsc): Delete?
+                               "Connection":     {"close"},
+                               "Content-Length": {"10"},
                        },
                        Close:         true,
                        ContentLength: 10,
@@ -170,7 +170,7 @@ var respTests = []respTest{
                        Request:          dummyReq("GET"),
                        Header:           Header{},
                        Close:            false,
-                       ContentLength:    -1, // TODO(rsc): Fix?
+                       ContentLength:    -1,
                        TransferEncoding: []string{"chunked"},
                },
 
index 488aeb938bb293cf5edabc89e577d3a418a5f784..4792bfba222df6154b853da8cc4ab907a8ee36b3 100644 (file)
@@ -4,9 +4,6 @@
 
 // HTTP server.  See RFC 2616.
 
-// TODO(rsc):
-//     logging
-
 package http
 
 import (