codereview: use subprocess.call() instead of os.spawnvp() for portability

Fixes #4121.

R=golang-dev, minux.ma, dave, r
CC=golang-dev
https://golang.org/cl/6555049

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 47317ad440e22007401acd048c8878f6ea6a2282..62553257bbb787f205cee6cf7194dc42e64046af 100644 (file)
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1772,7 +1772,7 @@ def gofmt(ui, repo, *pats, **opts):
                cmd = ["gofmt", "-l"]
                if not opts["list"]:
                        cmd += ["-w"]
-               if os.spawnvp(os.P_WAIT, "gofmt", cmd + files) != 0:
+               if subprocess.call(cmd + files) != 0:
                        raise hg_util.Abort("gofmt did not exit cleanly")
        except hg_error.Abort, e:
                raise