]> Cypherpunks repositories - gostls13.git/commitdiff
database/sql: do not rely on timeout for deadlock test
authorDaniel Theophanes <kardianos@gmail.com>
Wed, 16 Jun 2021 16:46:00 +0000 (11:46 -0500)
committerDaniel Theophanes <kardianos@gmail.com>
Sat, 19 Jun 2021 00:46:21 +0000 (00:46 +0000)
Fixes #46783

Change-Id: I8a8d1716279a041a7411c0c47a440a7997b39c80
Reviewed-on: https://go-review.googlesource.com/c/go/+/328649
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Carlos Amedee <carlos@golang.org>

src/database/sql/sql_test.go

index 80f63e877d002472b522f9b26cd4cd477f401807..7d1cb9b85a59bf48060f939cc6f861ea474cf01d 100644 (file)
@@ -2838,9 +2838,10 @@ func TestTxStmtDeadlock(t *testing.T) {
        db := newTestDB(t, "people")
        defer closeDB(t, db)
 
-       ctx, cancel := context.WithTimeout(context.Background(), 5*time.Millisecond)
+       ctx, cancel := context.WithCancel(context.Background())
        defer cancel()
        tx, err := db.BeginTx(ctx, nil)
+       cancel()
        if err != nil {
                t.Fatal(err)
        }