runtime: skip TestCrashDumpsAllThreads with mayMoreStackPreempt

This test is flaky with in mayMoreStackPreempt mode. This is probably
revealing a real bug in the scheduler, but since it seems to only
affect TestCrashDumpsAllThreads, which is itself testing a debug mode,
I don't think this is high priority.

Updates #55160.

Change-Id: Iac558c098930ad8d4392b1e82b34f55eaec77c48
Reviewed-on: https://go-review.googlesource.com/c/go/+/501229
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Auto-Submit: Austin Clements <austin@google.com>

diff --git a/src/runtime/crash_unix_test.go b/src/runtime/crash_unix_test.go
index a7d662478924e93c222594c983cdf769cad15365..07060b8fabaf8086295735fe3d42e8c075caaf00 100644 (file)
--- a/src/runtime/crash_unix_test.go
+++ b/src/runtime/crash_unix_test.go
@@ -14,6 +14,7 @@ import (
        "os/exec"
        "runtime"
        "runtime/debug"
+       "strings"
        "sync"
        "syscall"
        "testing"
@@ -75,12 +76,20 @@ func TestCrashDumpsAllThreads(t *testing.T) {
 
        testenv.MustHaveGoBuild(t)
 
+       if strings.Contains(os.Getenv("GCFLAGS"), "mayMoreStackPreempt") {
+               // This test occasionally times out in this debug mode. This is probably
+               // revealing a real bug in the scheduler, but since it seems to only
+               // affect this test and this is itself a test of a debug mode, it's not
+               // a high priority.
+               testenv.SkipFlaky(t, 55160)
+       }
+
        exe, err := buildTestProg(t, "testprog")
        if err != nil {
                t.Fatal(err)
        }
 
-       cmd := exec.Command(exe, "CrashDumpsAllThreads")
+       cmd := testenv.Command(t, exe, "CrashDumpsAllThreads")
        cmd = testenv.CleanCmdEnv(cmd)
        cmd.Env = append(cmd.Env,
                "GOTRACEBACK=crash",