]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/link: disable new testpoint on mips pending investigation
authorThan McIntosh <thanm@google.com>
Sat, 23 Nov 2019 14:59:30 +0000 (09:59 -0500)
committerThan McIntosh <thanm@google.com>
Sun, 24 Nov 2019 15:06:38 +0000 (15:06 +0000)
Skip TestMinusRSymsWithSameName testpoint on MIPS for the time being
since it triggers failures on that arch. Will re-enable once the
problems are fixed.

Updates #35779.

Change-Id: I3e6650158ab04a2be77e3db5a5194df3bbb0859e
Reviewed-on: https://go-review.googlesource.com/c/go/+/208557
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/link/elf_test.go

index 84f373af8ffc51b98dd860d5db119daabb796673..e9f727e919c100405cc5c03b29d87ba6c76e40b9 100644 (file)
@@ -13,6 +13,7 @@ import (
        "os"
        "os/exec"
        "path/filepath"
+       "runtime"
        "strings"
        "testing"
 )
@@ -132,12 +133,18 @@ int Cfunc2() { return blah(); }
 // TestMinusRSymsWithSameName tests a corner case in the new
 // loader. Prior to the fix this failed with the error 'loadelf:
 // $WORK/b001/_pkg_.a(ldr.syso): duplicate symbol reference: blah in
-// both main(.text) and main(.text)'
+// both main(.text) and main(.text)'. See issue #35779.
 func TestMinusRSymsWithSameName(t *testing.T) {
        testenv.MustHaveGoBuild(t)
        testenv.MustHaveCGO(t)
        t.Parallel()
 
+       // Skip this test on MIPS for the time being since it seems to trigger
+       // problems with unknown relocations.
+       if strings.Contains(runtime.GOARCH, "mips") {
+               testenv.SkipFlaky(t, 35779)
+       }
+
        dir, err := ioutil.TempDir("", "go-link-TestMinusRSymsWithSameName")
        if err != nil {
                t.Fatal(err)
@@ -197,7 +204,6 @@ func TestMinusRSymsWithSameName(t *testing.T) {
        cmd := exec.Command(goTool, "build")
        cmd.Dir = dir
        cmd.Env = env
-       t.Logf("%s build", goTool)
        if out, err := cmd.CombinedOutput(); err != nil {
                t.Logf("%s", out)
                t.Fatal(err)