]> Cypherpunks repositories - gostls13.git/commitdiff
misc/reboot: skip TestRepeatBootstrap on short builders
authorBryan C. Mills <bcmills@google.com>
Tue, 23 Nov 2021 15:54:49 +0000 (10:54 -0500)
committerBryan C. Mills <bcmills@google.com>
Tue, 23 Nov 2021 16:52:38 +0000 (16:52 +0000)
This test is slow and resource-intensive, and will rarely catch
failures. It is important to run sometimes, but probably a waste of
time on smaller (and especially reverse) builders.
Rather than hard-coding a list of small builders, only run it on the
longtest builders.

Fixes #35233
Fixes #30892
Fixes #49753

Change-Id: I25a9702e1f541246ea200fd7c79414ca5f69edae
Reviewed-on: https://go-review.googlesource.com/c/go/+/366538
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
misc/reboot/reboot_test.go

index 6bafc608b5e234a051c7a19c7e4282cea7297f21..ef164d32327bec41cf719d4b5bc39ed2238fb367 100644 (file)
@@ -15,6 +15,10 @@ import (
 )
 
 func TestRepeatBootstrap(t *testing.T) {
+       if testing.Short() {
+               t.Skipf("skipping test that rebuilds the entire toolchain")
+       }
+
        goroot, err := os.MkdirTemp("", "reboot-goroot")
        if err != nil {
                t.Fatal(err)