]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.15] runtime/pprof: skip tests for AIX
authorClément Chigot <chigot.c@gmail.com>
Thu, 1 Apr 2021 08:06:05 +0000 (10:06 +0200)
committerHeschi Kreinick <heschi@google.com>
Wed, 5 May 2021 21:11:25 +0000 (21:11 +0000)
Most of the time, the pprof tests are passing, except
for the builder. The reason is still unknown but I'd rather release
the builder to avoid missing other more important bugs.

Updates #45170

Change-Id: I667543ee1ae309b7319c5b3676a0901b4d0ecf2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/306489
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
(cherry picked from commit 7bfd681c2f11918c6245ad2906b2efc12eda2914)
Reviewed-on: https://go-review.googlesource.com/c/go/+/317369
Reviewed-by: Heschi Kreinick <heschi@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>

src/runtime/pprof/pprof_test.go

index 7149bfb31f0247f6e5f78cf7f42a7c3c7ce2060a..9c1c0972061a081606b11e9f3b72a43bcff65283 100644 (file)
@@ -280,7 +280,8 @@ func testCPUProfile(t *testing.T, matches matchFunc, need []string, avoid []stri
 
        broken := false
        switch runtime.GOOS {
-       case "darwin", "dragonfly", "netbsd", "illumos", "solaris":
+       // See https://golang.org/issue/45170 for AIX.
+       case "darwin", "dragonfly", "netbsd", "illumos", "solaris", "aix":
                broken = true
        case "openbsd":
                if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {