misc/dashboard/codereview: fix obo

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6443091

diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go
index 433232aa4fc25cf293d031108ec08423f2bb022c..4187ca6855baaaf87d64693291b780c3d2a3d600 100644 (file)
--- a/misc/dashboard/codereview/dashboard/cl.go
+++ b/misc/dashboard/codereview/dashboard/cl.go
@@ -148,7 +148,8 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
        }
 
        u := user.Current(c)
-       if _, ok := emailToPerson[u.Email]; !ok {
+       person, ok := emailToPerson[u.Email]
+       if !ok {
                http.Error(w, "Not allowed", http.StatusUnauthorized)
                return
        }
@@ -159,8 +160,7 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
                http.Error(w, "Bad CL", 400)
                return
        }
-       person, ok := preferredEmail[rev]
-       if !ok && rev != "" {
+       if _, ok := preferredEmail[rev]; !ok && rev != "" {
                c.Errorf("Unknown reviewer %q", rev)
                http.Error(w, "Unknown reviewer", 400)
                return