cmd/compile: avoid copying in nilcheckelim2

nilcheckelim2 cleans up by copying b.Values in a loop, omitting
OpUnknowns. However, the common case is that there are no OpUnknowns,
in which case we can skip a lot of work.

So we track the first nilcheck which was eliminated, if any, and only
start copying from there. If no nilcheck was eliminated we won't copy at all.

Fixes #20964

Change-Id: Icd44194cf8ac81ce6485ce257b4d33e093003a40
Reviewed-on: https://go-review.googlesource.com/65651
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>

diff --git a/src/cmd/compile/internal/ssa/nilcheck.go b/src/cmd/compile/internal/ssa/nilcheck.go
index f8c7a5019cb11b3902bbc2f1b8cf23ad667183de..1f789df2a8e0689a79cf6f454c5470bf8f834b0f 100644 (file)
--- a/src/cmd/compile/internal/ssa/nilcheck.go
+++ b/src/cmd/compile/internal/ssa/nilcheck.go
@@ -168,6 +168,8 @@ func nilcheckelim2(f *Func) {
                // input pointer is nil. Remove nil checks on those pointers, as the
                // faulting instruction effectively does the nil check for free.
                unnecessary.clear()
+               // Optimization: keep track of removed nilckeck with smallest index
+               firstToRemove := len(b.Values)
                for i := len(b.Values) - 1; i >= 0; i-- {
                        v := b.Values[i]
                        if opcodeTable[v.Op].nilCheck && unnecessary.contains(v.Args[0].ID) {
@@ -175,6 +177,7 @@ func nilcheckelim2(f *Func) {
                                        f.Warnl(v.Pos, "removed nil check")
                                }
                                v.reset(OpUnknown)
+                               firstToRemove = i
                                continue
                        }
                        if v.Type.IsMemory() || v.Type.IsTuple() && v.Type.FieldType(1).IsMemory() {
@@ -224,8 +227,9 @@ func nilcheckelim2(f *Func) {
                        }
                }
                // Remove values we've clobbered with OpUnknown.
-               i := 0
-               for _, v := range b.Values {
+               i := firstToRemove
+               for j := i; j < len(b.Values); j++ {
+                       v := b.Values[j]
                        if v.Op != OpUnknown {
                                b.Values[i] = v
                                i++