]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: adjust a substring which matches "uninteresting" goroutine
authorNevkontakte <aleks@nevkontakte.com>
Sat, 23 Oct 2021 14:02:25 +0000 (14:02 +0000)
committerDamien Neil <dneil@google.com>
Fri, 5 Nov 2021 21:34:10 +0000 (21:34 +0000)
This change allows the check to pass unmodified under GopherJS, which
stack traces are formatted differently (due to being generated by
NodeJS). There are no other functions named `interestingGoroutines` in
the standard library, so it's very unlikely to create false negatives,
and will allow reduce the number of overlays GopherJS needs to maintain.

Change-Id: I925594c6c313ca35805811f240c8528241950547
GitHub-Last-Rev: 26b32efb225c1ee85de0a51968c31b1a58d56f92
GitHub-Pull-Request: golang/go#49128
Reviewed-on: https://go-review.googlesource.com/c/go/+/358154
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Damien Neil <dneil@google.com>
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

src/net/http/main_test.go

index 632a308a5ce2eb0da306356e80d026e77689d054..27872b4e7a40f10409e85bc83e9d5dd96240f2a4 100644 (file)
@@ -43,7 +43,7 @@ func interestingGoroutines() (gs []string) {
                        // These only show up with GOTRACEBACK=2; Issue 5005 (comment 28)
                        strings.Contains(stack, "runtime.goexit") ||
                        strings.Contains(stack, "created by runtime.gc") ||
-                       strings.Contains(stack, "net/http_test.interestingGoroutines") ||
+                       strings.Contains(stack, "interestingGoroutines") ||
                        strings.Contains(stack, "runtime.MHeap_Scavenger") {
                        continue
                }