]> Cypherpunks repositories - gostls13.git/commitdiff
codereview: allow editing of local CL description
authorRuss Cox <rsc@golang.org>
Mon, 30 Nov 2009 18:28:48 +0000 (10:28 -0800)
committerRuss Cox <rsc@golang.org>
Mon, 30 Nov 2009 18:28:48 +0000 (10:28 -0800)
between hg clpatch and hg submit.

R=r
https://golang.org/cl/162059

lib/codereview/codereview.py

index e3331130a40d5218d432f975303b90b3acb2ff54..0be956b614d423380317a080bad4fef7e3f9cff1 100644 (file)
@@ -344,7 +344,14 @@ def LoadCL(ui, repo, name, web=True):
                        return None, "malformed response loading CL data from code review server"
                cl.reviewer = SplitCommaSpace(f['reviewers'])
                cl.cc = SplitCommaSpace(f['cc'])
-               cl.desc = f['description']
+               if cl.local and cl.original_author and cl.desc:
+                       # local copy of CL written by someone else
+                       # and we saved a description.  use that one,
+                       # so that committers can edit the description
+                       # before doing hg submit.
+                       pass
+               else:
+                       cl.desc = f['description']
                cl.url = server_url_base + name
                cl.web = True
        return cl, ''