misc/dashboard/builder: check http status before processing response

Occasionally GAE will return a 500 error response, don't treat this as a valid JSON body.

R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/6775066

diff --git a/misc/dashboard/builder/http.go b/misc/dashboard/builder/http.go
index e50ae572410011487d63e94b73fa70b6cc7ec1b9..b50e84551ba7534bc7c082a142208e32692e0783 100644 (file)
--- a/misc/dashboard/builder/http.go
+++ b/misc/dashboard/builder/http.go
@@ -56,8 +56,10 @@ func dash(meth, cmd string, args url.Values, req, resp interface{}) error {
        if err != nil {
                return err
        }
-
        defer r.Body.Close()
+       if r.StatusCode != http.StatusOK {
+               return fmt.Errorf("bad http response: %v", r.Status)
+       }
        body := new(bytes.Buffer)
        if _, err := body.ReadFrom(r.Body); err != nil {
                return err