]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: fix lineno restoration after SSA compilation
authorMatthew Dempsky <mdempsky@google.com>
Mon, 7 Mar 2016 18:12:19 +0000 (10:12 -0800)
committerMatthew Dempsky <mdempsky@google.com>
Tue, 8 Mar 2016 06:02:15 +0000 (06:02 +0000)
Without SSA:

$ go build -a -gcflags='-S -ssa=0' runtime 2>&1 | grep 'TEXT.*""\.init(SB)'
        0x0000 00000 ($GOROOT/src/runtime/write_err.go:14)        TEXT    "".init(SB), $88-0

With SSA, before this CL:

$ go build -a -gcflags='-S -ssa=1' runtime 2>&1 | grep 'TEXT.*""\.init(SB)'
        0x0000 00000 ($GOROOT/src/runtime/traceback.go:608)       TEXT    "".init(SB), $152-0

With SSA, after this CL:

$ go build -a -gcflags='-S -ssa=1' runtime 2>&1 | grep 'TEXT.*""\.init(SB)'
        0x0000 00000 ($GOROOT/src/runtime/write_err.go:14)        TEXT    "".init(SB), $152-0

Change-Id: Ida3541e03a1af6ffc753ee5c3abeb653459edbf6
Reviewed-on: https://go-review.googlesource.com/20321
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/gc/pgen.go

index cd6018e73689e429e887d9424ed6c7a84e129ade..37a0b2d4409844abc5f7291ee0982c83aa0e190c 100644 (file)
@@ -484,11 +484,8 @@ func compile(fn *Node) {
 
        if ssafn != nil {
                genssa(ssafn, ptxt, gcargs, gclocals)
-               if Curfn.Func.Endlineno != 0 {
-                       lineno = Curfn.Func.Endlineno
-               }
                ssafn.Free()
-               return
+               goto ret
        }
        Genlist(Curfn.Func.Enter)
        Genlist(Curfn.Nbody)