]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestSegv failures with "morestack on g0" on darwin/amd64
authorBryan C. Mills <bcmills@google.com>
Wed, 2 Feb 2022 15:19:30 +0000 (10:19 -0500)
committerBryan Mills <bcmills@google.com>
Thu, 3 Feb 2022 16:53:55 +0000 (16:53 +0000)
This failure mode has been present since at least 2020-06-08. We have
enough information to diagnose it, and further failures don't seem to
be adding any new information at this point: they can only add noise,
both on the Go project's builders and in users' own modules (for
example, when run as part of 'go test all').

For #39457

Change-Id: I2379631da0c8af69598fa61c0cc5ac0ea6ba8267
Reviewed-on: https://go-review.googlesource.com/c/go/+/382395
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/crash_cgo_test.go

index 9444554d3700e1e3574d5f6c77dd103571e27a63..dc8f6a7148517ffa4cfd8df263e512b1756457a6 100644 (file)
@@ -596,6 +596,9 @@ func TestSegv(t *testing.T) {
                        t.Log(got)
                        want := "SIGSEGV"
                        if !strings.Contains(got, want) {
+                               if runtime.GOOS == "darwin" && runtime.GOARCH == "amd64" && strings.Contains(got, "fatal: morestack on g0") {
+                                       testenv.SkipFlaky(t, 39457)
+                               }
                                t.Errorf("did not see %q in output", want)
                        }