]> Cypherpunks repositories - gostls13.git/commitdiff
runtime/pprof: mark dragonfly and solaris as bad at pprof
authorBrad Fitzpatrick <bradfitz@golang.org>
Tue, 2 Feb 2016 17:34:48 +0000 (17:34 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 2 Feb 2016 19:07:08 +0000 (19:07 +0000)
Updates #13841

Change-Id: I121bce054e2756c820c76444e51357f474b7f3d6
Reviewed-on: https://go-review.googlesource.com/19161
Reviewed-by: Russ Cox <rsc@golang.org>
src/runtime/pprof/pprof_test.go

index 621d21d3272faa36b527dd52ea501c142f36fee3..ab6b1835c570d66ef43e84a319a40237595ea2a5 100644 (file)
@@ -96,7 +96,7 @@ func parseProfile(t *testing.T, bytes []byte, f func(uintptr, []uintptr)) {
        if l < 5+3 {
                t.Logf("profile too short: %#x", val)
                if badOS[runtime.GOOS] {
-                       t.Skipf("ignoring failure on %s; see golang.org/issue/6047", runtime.GOOS)
+                       t.Skipf("ignoring failure on %s; see golang.org/issue/13841", runtime.GOOS)
                        return
                }
                t.FailNow()
@@ -171,7 +171,7 @@ func testCPUProfile(t *testing.T, need []string, f func(dur time.Duration)) {
        }
 
        if badOS[runtime.GOOS] {
-               t.Skipf("ignoring failure on %s; see golang.org/issue/6047", runtime.GOOS)
+               t.Skipf("ignoring failure on %s; see golang.org/issue/13841", runtime.GOOS)
                return
        }
        // Ignore the failure if the tests are running in a QEMU-based emulator,
@@ -420,11 +420,13 @@ func deepStack(depth int) int {
        return deepStack(depth-1) + 1
 }
 
-// Operating systems that are expected to fail the tests. See issue 6047.
+// Operating systems that are expected to fail the tests. See issue 13841.
 var badOS = map[string]bool{
-       "darwin": true,
-       "netbsd": true,
-       "plan9":  true,
+       "darwin":    true,
+       "netbsd":    true,
+       "plan9":     true,
+       "dragonfly": true,
+       "solaris":   true,
 }
 
 func TestBlockProfile(t *testing.T) {