go/types, types2: don't re-evaluate context string for each function argument (optimi...

Change-Id: Ie1b4d5b64350ea42484adea14df84cacd1d2653b
Reviewed-on: https://go-review.googlesource.com/c/go/+/344576
Trust: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>

diff --git a/src/cmd/compile/internal/types2/call.go b/src/cmd/compile/internal/types2/call.go
index 538fdc0fb70ec4b3738e574e83582a9f36db0c91..4bbc524856acf5f3cd4f8efbdbb9e09d1ef3b841 100644 (file)
--- a/src/cmd/compile/internal/types2/call.go
+++ b/src/cmd/compile/internal/types2/call.go
@@ -341,8 +341,11 @@ func (check *Checker) arguments(call *syntax.CallExpr, sig *Signature, targs []T
        }
 
        // check arguments
-       for i, a := range args {
-               check.assignment(a, sigParams.vars[i].typ, check.sprintf("argument to %s", call.Fun))
+       if len(args) > 0 {
+               context := check.sprintf("argument to %s", call.Fun)
+               for i, a := range args {
+                       check.assignment(a, sigParams.vars[i].typ, context)
+               }
        }
 
        return

diff --git a/src/go/types/call.go b/src/go/types/call.go
index 87eeef444b5b75d9de2e1de5302aba6438944324..fdecafb7811455aa031f9739db2d16d7cd7ba861 100644 (file)
--- a/src/go/types/call.go
+++ b/src/go/types/call.go
@@ -347,8 +347,11 @@ func (check *Checker) arguments(call *ast.CallExpr, sig *Signature, targs []Type
        }
 
        // check arguments
-       for i, a := range args {
-               check.assignment(a, sigParams.vars[i].typ, check.sprintf("argument to %s", call.Fun))
+       if len(args) > 0 {
+               context := check.sprintf("argument to %s", call.Fun)
+               for i, a := range args {
+                       check.assignment(a, sigParams.vars[i].typ, context)
+               }
        }
 
        return