]> Cypherpunks repositories - gostls13.git/commitdiff
bug: pointer arithmetic involving large offsets
authorRuss Cox <rsc@golang.org>
Tue, 9 Jun 2009 16:45:30 +0000 (09:45 -0700)
committerRuss Cox <rsc@golang.org>
Tue, 9 Jun 2009 16:45:30 +0000 (09:45 -0700)
needs to dereference the base pointer to make
sure it catches nil.

R=r,ken
DELTA=21  (21 added, 0 deleted, 0 changed)
OCL=30083
CL=30101

test/bugs/bug162.go [new file with mode: 0644]

diff --git a/test/bugs/bug162.go b/test/bugs/bug162.go
new file mode 100644 (file)
index 0000000..717f1f0
--- /dev/null
@@ -0,0 +1,25 @@
+// $G $D/$F.go && $L $F.$A && (! ./$A.out || echo BUG: should fail)
+
+// Copyright 2009 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+import "unsafe"
+
+var x byte
+
+func main() {
+       var p *[1<<30]byte = nil;
+       x = 123;
+
+       // The problem here is not the use of unsafe:
+       // it is that indexing into p[] with a large
+       // enough index jumps out of the unmapped section
+       // at the beginning of memory and into valid memory.
+       // Pointer offsets and array indices, if they are
+       // very large, need to dereference the base pointer
+       // to trigger a trap.
+       println(p[uintptr(unsafe.Pointer(&x))]);
+}