]> Cypherpunks repositories - gostls13.git/commitdiff
go/parser: correct comment in expectedErrors
authorMateusz Poliwczak <mpoliwczak34@gmail.com>
Tue, 5 Aug 2025 16:51:09 +0000 (18:51 +0200)
committerGopher Robot <gobot@golang.org>
Tue, 5 Aug 2025 17:41:10 +0000 (10:41 -0700)
If `here` were already the start of the comment, then
the `pos = here` assignment would be redundant. Since pos
is already the start of the comment.

Change-Id: I793334988951ae5441327cb62d7524b423155b74
Reviewed-on: https://go-review.googlesource.com/c/go/+/693295
Reviewed-by: Alan Donovan <adonovan@google.com>
Commit-Queue: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>

src/go/parser/error_test.go

index a4e17dd6dbff4feca9b519377b4bc8012cff238c..252325659cb752133cad8c4df2d71eade00e3653 100644 (file)
@@ -88,7 +88,7 @@ func expectedErrors(fset *token.FileSet, filename string, src []byte) map[token.
                        s := errRx.FindStringSubmatch(lit)
                        if len(s) == 3 {
                                if s[1] == "HERE" {
-                                       pos = here // start of comment
+                                       pos = here // position right after the previous token prior to comment
                                } else if s[1] == "AFTER" {
                                        pos += token.Pos(len(lit)) // end of comment
                                } else {