]> Cypherpunks repositories - gostls13.git/commitdiff
net/http, net/http/httputil: fix nits found by vet
authorMikio Hara <mikioh.mikioh@gmail.com>
Thu, 7 Jan 2016 00:36:52 +0000 (09:36 +0900)
committerMikio Hara <mikioh.mikioh@gmail.com>
Thu, 7 Jan 2016 01:01:33 +0000 (01:01 +0000)
Change-Id: Idf02428591f61dc58f654fdaf0e3a55f8b8a1060
Reviewed-on: https://go-review.googlesource.com/18350
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/httputil/reverseproxy_test.go
src/net/http/serve_test.go

index a944e8e0f544fbf9e62aba1da2aced3efdb84317..7f203d878f544ec5d222c6b91447542411296fe5 100644 (file)
@@ -392,7 +392,7 @@ func TestReverseProxy_Post(t *testing.T) {
        backend := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
                slurp, err := ioutil.ReadAll(r.Body)
                if err != nil {
-                       t.Error("Backend body read = %v", err)
+                       t.Errorf("Backend body read = %v", err)
                }
                if len(slurp) != len(requestBody) {
                        t.Errorf("Backend read %d request body bytes; want %d", len(slurp), len(requestBody))
index 772d527576720430b19d7a8ac976986bdd23ca4a..cbe85d255bb4d25f04d4e9525f82a5949de00c3a 100644 (file)
@@ -1077,7 +1077,7 @@ Try:
                }
        }
        if !ok {
-               t.Fatal("Failed to start up after %d tries", maxTries)
+               t.Fatalf("Failed to start up after %d tries", maxTries)
        }
        defer ln.Close()
        c, err := tls.Dial("tcp", ln.Addr().String(), &tls.Config{
@@ -2496,7 +2496,7 @@ func TestHijackBeforeRequestBodyRead(t *testing.T) {
                gone := w.(CloseNotifier).CloseNotify()
                slurp, err := ioutil.ReadAll(reqBody)
                if err != nil {
-                       t.Error("Body read: %v", err)
+                       t.Errorf("Body read: %v", err)
                        return
                }
                if len(slurp) != len(requestBody) {