]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestTimePprof on sanitizers
authorMichael Pratt <mpratt@google.com>
Wed, 21 May 2025 20:14:19 +0000 (16:14 -0400)
committerGopher Robot <gobot@golang.org>
Wed, 21 May 2025 20:46:23 +0000 (13:46 -0700)
This test asserts there is no external code, but the sanitizer runtimes
are external code.

Fixes #73783.

Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-race
Change-Id: I6a6a636cf93b7950e3ea35e00ec2eaf89911d712
Reviewed-on: https://go-review.googlesource.com/c/go/+/675296
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/runtime/crash_test.go

index 63c4426806ec51774270d7caedac6e0403020f1e..221a9a95cc21f8fb1f8321d04f8197e147bc9883 100644 (file)
@@ -854,6 +854,9 @@ func TestTimePprof(t *testing.T) {
        case "aix", "darwin", "illumos", "openbsd", "solaris":
                t.Skipf("skipping on %s because nanotime calls libc", runtime.GOOS)
        }
+       if race.Enabled || asan.Enabled || msan.Enabled {
+               t.Skip("skipping on sanitizers because the sanitizer runtime is external code")
+       }
 
        // Pass GOTRACEBACK for issue #41120 to try to get more
        // information on timeout.