gc: fix conversion of user-defined string type to []byte

Fixes #1709.

R=ken2
CC=golang-dev
https://golang.org/cl/4438068

diff --git a/src/cmd/gc/walk.c b/src/cmd/gc/walk.c
index 6b94002c5dfb8c32c589f71f34860ef0c7e00e60..ae556ae3fb1ee144e8ec98c8bf28eca963bbb42d 100644 (file)
--- a/src/cmd/gc/walk.c
+++ b/src/cmd/gc/walk.c
@@ -1356,7 +1356,7 @@ walkexpr(Node **np, NodeList **init)
 
        case OSTRARRAYBYTE:
                // stringtoslicebyte(string) []byte;
-               n = mkcall("stringtoslicebyte", n->type, init, n->left);
+               n = mkcall("stringtoslicebyte", n->type, init, conv(n->left, types[TSTRING]));
                goto ret;
 
        case OSTRARRAYRUNE:

diff --git a/test/fixedbugs/bug333.go b/test/fixedbugs/bug333.go
new file mode 100644 (file)
index 0000000..515c1f3
--- /dev/null
+++ b/test/fixedbugs/bug333.go
@@ -0,0 +1,19 @@
+// $G $D/$F.go && $L $F.$A && ./$A.out
+
+// Copyright 2011 The Go Authors.  All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Issue 1709
+
+package main
+
+func main() {
+       type Ts string
+       var ts Ts
+       _ = []byte(ts)
+}
+
+/*
+bug333.go:14: cannot use ts (type Ts) as type string in function argument
+*/