]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: remove always true comparison
authorTodd Neal <todd@tneal.org>
Tue, 25 Aug 2015 23:44:30 +0000 (18:44 -0500)
committerTodd Neal <todd@tneal.org>
Wed, 26 Aug 2015 04:55:58 +0000 (04:55 +0000)
byte is unsigned so the comparison against zero is always true.

Change-Id: I8fa60245972be362ae920507a291f92c0f9831ad
Reviewed-on: https://go-review.googlesource.com/13941
Run-TryBot: Todd Neal <todd@tneal.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/sniff.go

index 3be8c865d3b3933c18ecfa456ec99b322d1b9bdd..360296903118b529c5e75ccb7c6ddb807fbc2ef4 100644 (file)
@@ -209,7 +209,7 @@ func (textSig) match(data []byte, firstNonWS int) string {
        // c.f. section 5, step 4.
        for _, b := range data[firstNonWS:] {
                switch {
-               case 0x00 <= b && b <= 0x08,
+               case b <= 0x08,
                        b == 0x0B,
                        0x0E <= b && b <= 0x1A,
                        0x1C <= b && b <= 0x1F: