runtime: yield after raising signal that should kill process

Issue #15613 points out that the darwin builders have been getting
regular failures in which a process that should exit with a SIGPIPE
signal is instead exiting with exit status 2. The code calls
runtime.raise. On most systems runtime.raise is the equivalent of
pthread_kill(gettid(), sig); that is, it kills the thread with the
signal, which should ensure that the program does not keep going. On
darwin, however, runtime.raise is actually kill(getpid(), sig); that is,
it sends a signal to the entire process. If the process decides to
deliver the signal to a different thread, then it is possible that in
some cases the thread that calls raise is able to execute the next
system call before the signal is actually delivered. That would cause
the observed error.

I have not been able to recreate the problem myself, so I don't know
whether this actually fixes it. But, optimistically:

Fixed #15613.

Change-Id: I60c0a9912aae2f46143ca1388fd85e9c3fa9df1f
Reviewed-on: https://go-review.googlesource.com/23152
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/runtime/signal1_unix.go b/src/runtime/signal1_unix.go
index 31c1f2c4e58e9347fb64d5f83caf20ce65bd4a7c..5080202833e3d8fd16fcd381a8aae262303f06a1 100644 (file)
--- a/src/runtime/signal1_unix.go
+++ b/src/runtime/signal1_unix.go
@@ -193,7 +193,17 @@ func dieFromSignal(sig int32) {
        setsig(sig, _SIG_DFL, false)
        updatesigmask(sigmask{})
        raise(sig)
-       // That should have killed us; call exit just in case.
+
+       // That should have killed us. On some systems, though, raise
+       // sends the signal to the whole process rather than to just
+       // the current thread, which means that the signal may not yet
+       // have been delivered. Give other threads a chance to run and
+       // pick up the signal.
+       osyield()
+       osyield()
+       osyield()
+
+       // If we are still somehow running, just exit with the wrong status.
        exit(2)
 }