]> Cypherpunks repositories - gostls13.git/commitdiff
net: mark TestDialerDualStack as flaky
authorBrad Fitzpatrick <bradfitz@golang.org>
Thu, 23 Mar 2017 03:56:23 +0000 (03:56 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 23 Mar 2017 05:02:34 +0000 (05:02 +0000)
It was already marked flaky for everything but the dashboard.
Remove that restriction. It's just flaky overall.

It's doing more harm than good.

Updates #13324

Change-Id: I36feff32a1b8681e77700f74b9c70cb4073268eb
Reviewed-on: https://go-review.googlesource.com/38459
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/net/dial_test.go

index 9825bc92abc69adaa85ce4904a4dfa8056b01767..e8547974b95b88429f1b685523c42035dd6d2819 100644 (file)
@@ -715,11 +715,8 @@ func TestDialerLocalAddr(t *testing.T) {
 }
 
 func TestDialerDualStack(t *testing.T) {
-       // This test is known to be flaky. Don't frighten regular
-       // users about it; only fail on the build dashboard.
-       if testenv.Builder() == "" {
-               testenv.SkipFlaky(t, 13324)
-       }
+       testenv.SkipFlaky(t, 13324)
+
        if !supportsIPv4 || !supportsIPv6 {
                t.Skip("both IPv4 and IPv6 are required")
        }