]> Cypherpunks repositories - gostls13.git/commitdiff
syscall: skip TestSyscallNoError on rooted android/arm
authorBen Shi <powerman1st@163.com>
Thu, 30 Aug 2018 10:08:34 +0000 (10:08 +0000)
committerTobias Klauser <tobias.klauser@gmail.com>
Thu, 30 Aug 2018 11:14:39 +0000 (11:14 +0000)
The system call geteuid can not work properly on android, which
causes a test case failed on rooted android/arm.

This CL disables the test case on android.

Fixes #27364

Change-Id: Ibfd33ef8cc1dfe8822c8be4280eae12ee30929c1
Reviewed-on: https://go-review.googlesource.com/132175
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
src/syscall/syscall_linux_test.go

index 99de6ebaf2fcb14645e55f865df9d4524a00eff1..1fd70b07e3ef55f5f3db3100089484870ee69bc7 100644 (file)
@@ -302,6 +302,10 @@ func TestSyscallNoError(t *testing.T) {
                t.Skip("skipping root only test")
        }
 
+       if runtime.GOOS == "android" {
+               t.Skip("skipping on rooted android, see issue 27364")
+       }
+
        // Copy the test binary to a location that a non-root user can read/execute
        // after we drop privileges
        tempDir, err := ioutil.TempDir("", "TestSyscallNoError")