]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: prefer base.Fatalf to panic in dwarfgen
authorDerek Parker <parkerderek86@gmail.com>
Mon, 14 Jul 2025 22:28:59 +0000 (22:28 +0000)
committerGopher Robot <gobot@golang.org>
Thu, 24 Jul 2025 17:17:56 +0000 (10:17 -0700)
Updates a few spots which call `panic` to instead call `base.Fatalf`.

Change-Id: I30b73c7994caa647245b0e253f20e0b88185e644
GitHub-Last-Rev: b3839bbe424294f92a1f9448e5e0ac074e722e4d
GitHub-Pull-Request: golang/go#74616
Reviewed-on: https://go-review.googlesource.com/c/go/+/688035
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/compile/internal/dwarfgen/dwarf.go

index 7d75c0c5ce38d7778671501fa7c8919ee6f6a12b..6ab39d2aaad1cf8708c13af0a12406f8baeee3aa 100644 (file)
@@ -203,7 +203,7 @@ func createDwarfVars(fnsym *obj.LSym, complexOK bool, fn *ir.Func, apDecls []*ir
                                continue
                        }
                        if n.Class != ir.PPARAMOUT || !n.IsOutputParamInRegisters() {
-                               panic("invalid ir.Name on debugInfo.RegOutputParams list")
+                               base.Fatalf("invalid ir.Name on debugInfo.RegOutputParams list")
                        }
                        dcl = append(dcl, n)
                }
@@ -583,7 +583,7 @@ func createHeapDerefLocationList(n *ir.Name, entryID ssa.ID) []byte {
 // in the DWARF info.
 func RecordFlags(flags ...string) {
        if base.Ctxt.Pkgpath == "" {
-               panic("missing pkgpath")
+               base.Fatalf("missing pkgpath")
        }
 
        type BoolFlag interface {