]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.19] net: disable TestLookupDotsWithRemoteSource and TestLookupGoo...
authorMichael Anthony Knyszek <mknyszek@google.com>
Fri, 11 Nov 2022 17:26:45 +0000 (17:26 +0000)
committerMichael Knyszek <mknyszek@google.com>
Fri, 11 Nov 2022 21:32:30 +0000 (21:32 +0000)
These tests fail consistently due to a DNS change causing widespread
trybot outages.

For #56707.
Fixes #56710.

Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/449640
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
(cherry picked from commit 97765249082b6835c77517a4e63bb38cfd6db97b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/449506
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/net/lookup_test.go

index 3a31f56bea845056a6afe3ebe2b12a28b2ef9577..655543c7d21b2d290dc2466e78edbe54f7d7deef 100644 (file)
@@ -71,6 +71,10 @@ var lookupGoogleSRVTests = []struct {
 var backoffDuration = [...]time.Duration{time.Second, 5 * time.Second, 30 * time.Second}
 
 func TestLookupGoogleSRV(t *testing.T) {
+       // TODO(mknyszek): Figure out next steps for this test. This is just
+       // a quick fix.
+       t.Skip("fails consistently due to an upstream DNS change; see #56707.")
+
        t.Parallel()
        mustHaveExternalNetwork(t)
 
@@ -631,6 +635,10 @@ func TestLookupDotsWithLocalSource(t *testing.T) {
 }
 
 func TestLookupDotsWithRemoteSource(t *testing.T) {
+       // TODO(mknyszek): Figure out next steps for this test. This is just
+       // a quick fix.
+       t.Skip("fails consistently due to an upstream DNS change; see #56707.")
+
        if runtime.GOOS == "darwin" || runtime.GOOS == "ios" {
                testenv.SkipFlaky(t, 27992)
        }