]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: ignore packages with no Go files in BenchmarkAll
authorIan Lance Taylor <iant@golang.org>
Tue, 14 Jan 2025 14:58:32 +0000 (06:58 -0800)
committerGopher Robot <gobot@golang.org>
Tue, 14 Jan 2025 15:27:27 +0000 (07:27 -0800)
This case recently started happening on the builders.
The synctest experiment was recently enabled for some targets (CL 642422).
This caused the list of standard packages to include testing/synctest.
However, BenchmarkAll tests for all configurations;
some did not include testing/synctest. That caused the test to crash.

Change-Id: Icade10af147c2e2bcbac25bf744919083db3e70f
Reviewed-on: https://go-review.googlesource.com/c/go/+/642397
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/api/api_test.go

index 78482333330bd8bce36d69e385b6e901ecd90a06..cac624af8a6530cb4285157cf3069e513fb27d7e 100644 (file)
@@ -201,7 +201,10 @@ func BenchmarkAll(b *testing.B) {
                for _, context := range contexts {
                        w := NewWalker(context, filepath.Join(testenv.GOROOT(b), "src"))
                        for _, name := range w.stdPackages {
-                               pkg, _ := w.import_(name)
+                               pkg, err := w.import_(name)
+                               if _, nogo := err.(*build.NoGoError); nogo {
+                                       continue
+                               }
                                w.export(pkg)
                        }
                        w.Features()