internal,runtime: use the builtin clear

To simplify the code.

Change-Id: I023de705504c0b580718eec3c7c563b6cf2c8184
GitHub-Last-Rev: 026b32c799b13d0c7ded54f2e61429e6c5ed0aa8
GitHub-Pull-Request: golang/go#73412
Reviewed-on: https://go-review.googlesource.com/c/go/+/666118
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>

diff --git a/src/internal/profile/graph.go b/src/internal/profile/graph.go
index 0e8e33c1ac4b9b2535cd96a73516d7eaaaf4b5c8..e3c755a65d85234425b7dac6c21cd8aa77877962 100644 (file)
--- a/src/internal/profile/graph.go
+++ b/src/internal/profile/graph.go
@@ -253,12 +253,8 @@ func NewGraph(prof *Profile, o *Options) *Graph {
                if dw == 0 && w == 0 {
                        continue
                }
-               for k := range seenNode {
-                       delete(seenNode, k)
-               }
-               for k := range seenEdge {
-                       delete(seenEdge, k)
-               }
+               clear(seenNode)
+               clear(seenEdge)
                var parent *Node
                // A residual edge goes over one or more nodes that were not kept.
                residual := false

diff --git a/src/internal/zstd/xxhash.go b/src/internal/zstd/xxhash.go
index 4d579ee2d5c0d61e621cdfb37f2aada82336d897..51d5ff89603460443a3bf43ee0aeed3bbe585f8e 100644 (file)
--- a/src/internal/zstd/xxhash.go
+++ b/src/internal/zstd/xxhash.go
@@ -41,9 +41,7 @@ func (xh *xxhash64) reset() {
        xh.v[3] = xxhPrime64c1
        xh.v[3] = -xh.v[3]
 
-       for i := range xh.buf {
-               xh.buf[i] = 0
-       }
+       clear(xh.buf[:])
        xh.cnt = 0
 }
 

diff --git a/src/runtime/mstats.go b/src/runtime/mstats.go
index c10ca402217cfb301b644f1a17b3684bc4a169af..888798c600d6c0ae4f6171a70df1d6930661d892 100644 (file)
--- a/src/runtime/mstats.go
+++ b/src/runtime/mstats.go
@@ -834,9 +834,7 @@ func (m *consistentHeapStats) unsafeRead(out *heapStatsDelta) {
 func (m *consistentHeapStats) unsafeClear() {
        assertWorldStopped()
 
-       for i := range m.stats {
-               m.stats[i] = heapStatsDelta{}
-       }
+       clear(m.stats[:])
 }
 
 // read takes a globally consistent snapshot of m

diff --git a/src/runtime/proc.go b/src/runtime/proc.go
index 8f07b39360afd1e041af8b6286f0604e436a09e4..db7a5b2bb1c654568139595b070de4c9dab24c3f 100644 (file)
--- a/src/runtime/proc.go
+++ b/src/runtime/proc.go
@@ -5690,14 +5690,10 @@ func (pp *p) destroy() {
                wbBufFlush1(pp)
                pp.gcw.dispose()
        }
-       for i := range pp.sudogbuf {
-               pp.sudogbuf[i] = nil
-       }
+       clear(pp.sudogbuf[:])
        pp.sudogcache = pp.sudogbuf[:0]
        pp.pinnerCache = nil
-       for j := range pp.deferpoolbuf {
-               pp.deferpoolbuf[j] = nil
-       }
+       clear(pp.deferpoolbuf[:])
        pp.deferpool = pp.deferpoolbuf[:0]
        systemstack(func() {
                for i := 0; i < pp.mspancache.len; i++ {