]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.18] cmd/link: stop passing -pagezero_size to darwin linker
authorCherry Mui <cherryyz@google.com>
Wed, 14 Sep 2022 23:50:00 +0000 (19:50 -0400)
committerCherry Mui <cherryyz@google.com>
Wed, 21 Sep 2022 20:27:25 +0000 (20:27 +0000)
We added -pagezero_size in CL 72730, where it was intented for iOS.
The current code passes it only on macOS/AMD64 instead. It is not
really necessary there. Also, the new darwin linker starts to emit
a warning about deprecation of the flag. Stop passing it.

For #55113
Updates #54482, #55112.

Change-Id: If9db7a1645c37d4284e48f075856912df8d8c1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/430936
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 5231ba2f054f2ecb1387bad00b8745d6fe532ea4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/431516
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/link/internal/ld/lib.go

index f1a37e955e93706e2324d1d476041616fd939c29..5fb0b3d21f31ca01cffd6cf08dee7e92e169c314 100644 (file)
@@ -1324,7 +1324,6 @@ func (ctxt *Link) hostlink() {
                if ctxt.HeadType == objabi.Hdarwin {
                        if machoPlatform == PLATFORM_MACOS && ctxt.IsAMD64() {
                                argv = append(argv, "-Wl,-no_pie")
-                               argv = append(argv, "-Wl,-pagezero_size,4000000")
                        }
                }
        case BuildModePIE: